Re: [Xen-devel] [PATCH 6/18 V2]: PVH xen: Introduce PVH guest type

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Mon, 25 Mar 2013 09:26:51 +0000
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 23.03.13 at 02:13, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > On Tue, 19 Mar 2013 08:48:53 +0000
> > "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> > 
> >> > suggest we leave it as is. is_hvm_or_pvh_domain is nicely
> >> > readable, what name do you suggest?
> >> 
> >> No. The three kinds should be fully distinct, such that when
> >> meaning one you can use is_xyz_domain() and when meaning
> >> two, you can use !is_abc_domain().
> > 
> >> is_hvm_or_pvh_domain() isn't nicely readable to me, in particular
> >> because this kind of naming doesn't scale. And it's certainly more
> >> typing than !is_pv_domain().
> > 
> > Since, pvh is a pv domain, I don't like using pv_guest for non PVH
> > PV. But perhaps I could use the name pv_mmu and have something like
> > following:
> > 
> > enum guest_type { is_mmu_pv, is_pvh_pv, is_hvm } guest_type;
> > 
> > Then:  is_hvm_or_pvh_domain()  becomes:  !is_mmu_pv().
> > 
> > Alternative to is_mmu_pv: is_pure_pv, is_orig_pv, ....
> 
> These are all ugly, and I don't see why the triplet I suggested
> (is_pv, is_pvh, and is_hvm), including their intended use, wouldn't
> be acceptable.

Because this implies pvh is a new type, whereas like I said before,
PVH is a PV guest. Ok, lets go with your suggestion above, and if
people find it confusing, we can change in future.

Thanks,
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel