Re: [Xen-devel] [PATCH 11/12] xen/events: Add the hypervisor interface for the FIFO-based event channels

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, 2013-03-20 at 14:18 +0000, David Vrabel wrote:
> On 20/03/13 14:03, Wei Liu wrote:
> > On Tue, 2013-03-19 at 21:04 +0000, David Vrabel wrote:
> >> From: David Vrabel <david.vrabel@xxxxxxxxxx>
> >>
> >> Add the hypercall sub-ops and the structures for the shared data used
> >> in the FIFO-based event channel ABI.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> >> ---
> >>  include/xen/interface/event_channel.h |   70 
> >> +++++++++++++++++++++++++++++++++
> >>  1 files changed, 70 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/xen/interface/event_channel.h 
> >> b/include/xen/interface/event_channel.h
> >> index f494292..10472f5 100644
> >> --- a/include/xen/interface/event_channel.h
> >> +++ b/include/xen/interface/event_channel.h
> >> @@ -190,6 +190,50 @@ struct evtchn_reset {
> >>  };
> >>  typedef struct evtchn_reset evtchn_reset_t;
> >>  
> > 
> > This typedef slipped into the header and should be removed. No typedef
> > in Linux header.
> 
> This has nothing to do with this series.
> 

IIRC this one was my fault when I upstreamed evtchn_reset. I have a
trivial patch to remove it.

> However, I will make sure I don't add any more typedefs for structures.
> 

Yes please.


Wei.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel