[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.
Il 19/03/2013 16:13, Stefano Stabellini ha scritto:
> This patch only impacts the PV backend in QEMU, not the IDE interface.
> PV frontends and backends always disconnect and reconnect during
> save/restore.
> So we can be *certain* that bdrv_close at the sender side is called
> before the new connection is established at the receiver side.
>From the little I remember about Xen, they go to XenbusStateClosed on
the source before invoking the suspend hypercall? And then restart on
the destination?
If so, that sounds right. Thanks for finding an elegant solution.
> Unfortunately the QEMU PV backend opens the disk during initialization,
> so before the actual connection is established (blk_init).
>
> Therefore I think that the current change is not safe, but it is pretty
> easy to make it safe.
> You just need to move the call to blk_open from blk_init to blk_connect.
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
