Re: [Xen-devel] [PATCH 15/18 V2]: PVH xen: grant related changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 16.03.13 at 02:03, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> +    /* PVH: Because we free the existing mfn in XENMEM_add_to_physmap during
> +     * map, we undo that here so the guest P2M (EPT/NPT) is consistent */
> +    if ( is_pvh_domain(d) ) {
> +        struct page_info *page = alloc_domheap_page(d, 0);
> +
> +        if ( page == NULL ) {
> +            gdprintk(XENLOG_ERR, "domid:%d Unable to alloc domheap page\n",
> +                     d->domain_id);

gdprintk() is inappropriate for cases where the subject domain is not
current->domain. Or if it is, printing the domain ID is already being
taken care of by that macro wrapper.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel