[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] perf: Check all MSRs before passing hw check
>>> On 15.03.13 at 15:43, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: > On 15/03/13 12:50, Jan Beulich wrote: >>>>> On 15.03.13 at 13:20, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: >>> + if (bios_fail) { >>> + /* >>> + * We still allow the PMU driver to operate: >>> + */ >>> + printk(KERN_CONT "Broken BIOS detected, complain to your >>> hardware vendor.\n"); >>> + printk(KERN_ERR FW_BUG "the BIOS has corrupted hw-PMU resources >>> (MSR %x is %Lx)\n", reg, val); >> The values being printed here are not meaningful anymore with this >> patch. > > Right -- then I guess the options are: > 1. Don't print any values > 2. Print values on the first broken MSR detected (but not subsequent ones) > 3. Print values on all broken MSRs. > > #2 is the current behavior, and won't risk spamming the console. I tend to agree that #2 is best, but the x86/perf maintainers will have the final say anyway. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |