[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4 of 5 v3] tools/ocaml: libxc bindings: Fix stub_xc_readconsolering()

On Wed, 2013-03-13 at 11:15 +0000, Ian Jackson wrote:
> Dave Scott writes ("RE: [Xen-devel] [PATCH 4 of 5 v3] tools/ocaml: libxc 
> bindings: Fix stub_xc_readconsolering()"):
> > This looks fine to me. I assume the console ring is a C string which
> > doesn't contain NULLs in the middle and hence it's sensible to use
> > "caml_copy_string" (the alternative would be to treat it as a raw
> > block of bytes using "caml_alloc_string" and memcpy-- OCaml strings
> > can contain NULLs safely)
> The guest is certainly able to write nuls into the console ring if it
> wants to.

This is the hypervisor's console ring, not the guests.

But you are right that a guest can write to that in debug builds with
sufficient logging enabled on the command line.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.