Re: [Xen-devel] [PATCH 5/6] xl: export 'outstanding_pages' value from xcinfo

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-03-11 at 14:20 +0000, Konrad Rzeszutek Wilk wrote:
> This patch provides the value of claimed pages but not yet
> accounted for in a domain (outstanding). This value is initially set
> by the XENMEM_claim_pages hypercall and as the guest is being
> created its values decreases to zero.
> 
> With this patch it is possible to see the value of this
> field.
> 
> [v2: s/unclaimed/outstanding/ per Tim's suggestion]
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  tools/libxl/libxl.c         | 1 +
>  tools/libxl/libxl_types.idl | 1 +
>  tools/libxl/xl_sxp.c        | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 8c6e1a1..0745888 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -528,6 +528,7 @@ static void xcinfo2xlinfo(const xc_domaininfo_t *xcinfo,
>      else
>          xlinfo->shutdown_reason  = ~0;
>  
> +    xlinfo->outstanding_memkb = PAGE_TO_MEMKB(xcinfo->outstanding_pages);
>      xlinfo->current_memkb = PAGE_TO_MEMKB(xcinfo->tot_pages);
>      xlinfo->shared_memkb = PAGE_TO_MEMKB(xcinfo->shr_pages);
>      xlinfo->paged_memkb = PAGE_TO_MEMKB(xcinfo->paged_pages);
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index e417851..0a8b99a 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -201,6 +201,7 @@ libxl_dominfo = Struct("dominfo",[
>      # Otherwise set to a value guaranteed not to clash with any valid
>      # LIBXL_SHUTDOWN_REASON_* constant.
>      ("shutdown_reason", libxl_shutdown_reason),
> +    ("outstanding_memkb",  MemKB),
>      ("current_memkb",   MemKB),
>      ("shared_memkb", MemKB),
>      ("paged_memkb", MemKB),
> diff --git a/tools/libxl/xl_sxp.c b/tools/libxl/xl_sxp.c
> index a16a025..798f99d 100644
> --- a/tools/libxl/xl_sxp.c
> +++ b/tools/libxl/xl_sxp.c

Please don't patch this file, it is purely for legacy compatibility and
doesn't want or need to reflect new features.

Otherwise: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> @@ -72,6 +72,7 @@ void printf_info_sexp(int domid, libxl_domain_config 
> *d_config)
>      printf("\t(build_info)\n");
>      printf("\t(max_vcpus %d)\n", b_info->max_vcpus);
>      printf("\t(tsc_mode %s)\n", libxl_tsc_mode_to_string(b_info->tsc_mode));
> +    printf("\t(outstanding_memkb %"PRId64")\n", info.outstanding_memkb);
>      printf("\t(max_memkb %"PRId64")\n", b_info->max_memkb);
>      printf("\t(target_memkb %"PRId64")\n", b_info->target_memkb);
>      printf("\t(nomigrate %s)\n",



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel