Re: [Xen-devel] [PATCH 2 of 5 v2] tools/libxc: Helper function for XEN_SYSCTL_consoleringsize

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-02-21 at 15:46 +0000, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> diff -r 1306e69a7018 -r 1ffce9bf90f5 tools/libxc/xc_misc.c
> --- a/tools/libxc/xc_misc.c
> +++ b/tools/libxc/xc_misc.c
> @@ -100,6 +100,26 @@ int xc_readconsolering(xc_interface *xch
>      return ret;
>  }
>  
> +int xc_consoleringsize(xc_interface *xch, uint64_t * psize)
> +{
> +    int ret = -1;
> +    DECLARE_SYSCTL;
> +
> +    if ( ! psize )
> +    {
> +        errno = EFAULT;

Strictly I think this is an EINVAL event. EFAULT would be when it is
non-NULL but dereferencing it faults.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel