Re: [Xen-devel] [PATCH 2 of 5] tools/xc: document printf calls in xc_restore

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-03-12 at 16:47 +0000, Olaf Hering wrote:
> On Tue, Mar 12, Ian Campbell wrote:
> 
> > On Wed, 2013-03-06 at 16:48 +0000, Olaf Hering wrote:
> > > # HG changeset patch
> > > # User Olaf Hering <olaf@xxxxxxxxx>
> > > # Date 1362584522 -3600
> > > # Node ID 49b90990442aca9523acbf889cbb517ea44d20b4
> > > # Parent  e5ae0e680b5c64d7808bb6a68ea47ef1bbf68a51
> > > tools/xc: document printf calls in xc_restore
> > > 
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > > 
> > > diff -r e5ae0e680b5c -r 49b90990442a tools/xcutils/xc_restore.c
> > > --- a/tools/xcutils/xc_restore.c
> > > +++ b/tools/xcutils/xc_restore.c
> > > @@ -56,6 +56,7 @@ main(int argc, char **argv)
> > >  
> > >      if ( ret == 0 )
> > >      {
> > > +        /* xend expects this output, part of protocol */
> > 
> > xc_restore is effectively part of xend (just factored into its own
> > process), no one else uses this stuff.
> > 
> > What I guess I'm saying is that we can take everything which this file
> > does as being desired by xend...
> 
> The purpose is more to not convert them to DPRINTF or something, like I
> did it once until I realized that these printf calls should stay as is.

Ah, right. That's fair enough -- are there other such strings or just
that one? If there are many then #define XEND_RESPONSE ?

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel