Re: [Xen-devel] [PATCH v2 4/4] xl: add vif.default.script

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-02-06 at 18:04 +0000, Roger Pau Monne wrote:
> Replace vifscript with vif.default.script. The old config option is
> kept for backwards compatibility.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/libxl/xl.c |   11 ++++++++++-

Needs docs changes too I expect.

>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
> index 100ab32..92565d1 100644
> --- a/tools/libxl/xl.c
> +++ b/tools/libxl/xl.c
> @@ -86,8 +86,17 @@ static void parse_global_config(const char *configfile,
>          exit(1);
>      }
>  
> -    if (!xlu_cfg_get_string (config, "vifscript", &buf, 0))
> +    if (!xlu_cfg_get_string (config, "vifscript", &buf, 0)) {
> +        fprintf(stderr, "the global config option vifscript is deprecated, "
> +                        "please switch to vif.default.script\n");
> +        free(default_vifscript);
>          default_vifscript = strdup(buf);
> +    }
> +
> +    if (!xlu_cfg_get_string (config, "vif.default.script", &buf, 0)) {
> +        free(default_vifscript);
> +        default_vifscript = strdup(buf);
> +    }

Same comment as 3/4 about checking the deprecated name second.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel