Re: [Xen-devel] [PATCH 01 of 11 v3] xen, libxc: rename xenctl_cpumap to xenctl_bitmap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-02-01 at 11:01 +0000, Dario Faggioli wrote:
> This is in preparation of introducing NUMA node-affinity maps.

The second patch doesn't use this new infrastrucuture though, and has
"typedef uint8_t *xc_nodemap_t" instead. Which makes sense since a
node-affinity map is not a bitmap, is it?

> diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
> --- a/xen/include/public/xen.h
> +++ b/xen/include/public/xen.h
> @@ -851,9 +851,9 @@ typedef uint8_t xen_domain_handle_t[16];
>  #endif
> 
>  #ifndef __ASSEMBLY__
> -struct xenctl_cpumap {
> +struct xenctl_bitmap {
>      XEN_GUEST_HANDLE_64(uint8) bitmap;
> -    uint32_t nr_cpus;
> +    uint32_t nr_elems;

Is this really "nr_bits" or can an entry in the bitmap be > 1 bit?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel