Re: [Xen-devel] [PATCH v2] Xen/ACPI: support sleep state entering on hardware reduced systems

["Zheng, Lv" <lv.zheng@xxxxxxxxx>]

> > +#include <linux/acpi.h>

This line shouldn't appear in ACPICA codes (drivers/acpi/acpica).
Please try to declare OSL interfaces via include/acpi/platform/aclinux.h.

> >
> > +   status = acpi_os_prepare_sleep(sleep_state, acpi_gbl_sleep_type_a,
> > +                                  acpi_gbl_sleep_type_b, true);

bool is not used in ACPICA, please try u8 instead.

> >     status = acpi_os_prepare_sleep(sleep_state, pm1a_control,
> > -                                  pm1b_control);
> > +                                  pm1b_control, false);

Likewise.

> > -acpi_status acpi_os_prepare_sleep(u8 sleep_state, u32 pm1a_control,
> > -                             u32 pm1b_control)
> > +acpi_status acpi_os_prepare_sleep(u8 sleep_state, u32 val_a, u32 val_b,
> > +                             bool extended)

Is this an ACPICA OSL interface? Then it should not include bool parameter.

Thanks
-Lv

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel