Re: [Xen-devel] [PATCH 5/8] kexec: extend hypercall with improved load/unload ops

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, Mar 11, 2013 at 01:21:30PM +0000, David Vrabel wrote:
> On 11/03/13 11:17, Daniel Kiper wrote:
> >
> > Heh... It looks that there is a misunderstanding. At first I thought
> > that David was going to replace purgatory functionality by switching
> > from 64-bit to 32-bit in kexec_reloc. But later I realized that
> > I missed Xen 64-bit/dom 32-bit case. Now I agree that this switch
> > must stay as is. However, now I think that there is another
> > small mistake which should be fixed. Please look above.
>
> Which mistake?  I'm not sure what you're referring to.

I thought about that:

if ( image->arch == EM_386 )
  reloc_flags |= KEXEC_RELOC_FLAG_COMPAT;

It should be change to:

if ( is_pv_32on64_domain(dom0) )
  reloc_flags |= KEXEC_RELOC_FLAG_COMPAT;

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel