[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4] powernow: add fixups for AMD P-state figures

>>> On 08.03.13 at 15:27, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> ----- JBeulich@xxxxxxxx wrote:
>> Do the MSR access here (and while at it, also the one reading
>> MSR_PSTATE_CUR_LIMIT) on the target CPU, and bound the loop over
>> amd_fixup_frequency() by max_hw_pstate (matching the one in
>> powernow_cpufreq_cpu_init()).
> If we are bounding the loop at the top by max_hw_pstate 
> (MSRC001_0061[PstateMaxVal]), should we perhaps also bound it at 
> the bottom with MSRC001_0061[CurPstateLimit], to be consistent?

Don't know, and wouldn't want to do this in this patch (as the code
before didn't do so either). I'm fine with looking at an incremental
one though (which then updates _both_ affected loops).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.