[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

On 08/03/13 10:50, Alex Bligh wrote:

--On 8 March 2013 10:35:43 +0000 George Dunlap <George.Dunlap@xxxxxxxxxxxxx> 

If you can verify that it's always safe to use qemu without O_DIRECT
(or that it's not any safer to use it), then you should just remove
it; no point in having options which have no practical effect.  But in
that case you should make sure to mention in the commit message why
O_DIRECT isn't actually needed.
How about me adding the following:

This brings PV devices in line with emulated devices. Removing O_DIRECT
is safe as barrier operations are now correctly passed through.

That sounds good to me -- thanks, Alex.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.