Re: [Xen-devel] [PATCH 2/5] x86/mm: warn if we ever run out of shadow/hap pool for p2m/lgd ops.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.03.13 at 16:22, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/03/13 14:53, Tim Deegan wrote:
>> --- a/xen/arch/x86/mm/shadow/common.c
>> +++ b/xen/arch/x86/mm/shadow/common.c
>> @@ -1591,10 +1591,16 @@ shadow_alloc_p2m_page(struct domain *d)
>>      if ( d->arch.paging.shadow.total_pages 
>>           < shadow_min_acceptable_pages(d) + 1 )
>>      {
>> +        if ( !d->arch.paging.p2m_alloc_failed )
>> +        {
>> +            d->arch.paging.p2m_alloc_failed = 1;
>> +            dprintk(XENLOG_ERR, "d%i failed to allocate from shadow pool",
>> +                    d->domain_id);
> 
> domian_id is a uint16_t so %i is the wrong signedness and width.

How that? Everything smaller than an int gets promoted to int
first.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel