[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] tools/xenconsoled: Initialise pointers before trying to use them

This is a regression introduced by

"Switch from select() to poll() in xenconsoled's IO loop."
  hg c/s 26405:7359c3122c5d
  git cc5434c933153c4b8812d1df901f8915c22830a8

which results in reliable segfaults during VM power operations.

Signed-off-by: Marcus Granado <marcus.granado@xxxxxxxxxx>
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


These segfaults are 100% reproducible in a XenServer system when rebooting a
PV domain. I am at a loss to explain why the OSS testing has not picked them up.

diff -r 94ece33caae2 -r f66d74cbf492 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -669,6 +669,7 @@ static struct domain *create_domain(int 
        strcat(dom->conspath, "/console");
        dom->master_fd = -1;
+       dom->master_pollfd = NULL;
        dom->slave_fd = -1;
        dom->log_fd = -1;
@@ -687,6 +688,7 @@ static struct domain *create_domain(int 
        dom->remote_port = -1;
        dom->interface = NULL;
        dom->xce_handle = NULL;
+       dom->xce_pollfd = NULL;
        if (!watch_domain(dom, true))
                goto out;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.