Re: [Xen-devel] [PATCH 1/1] xen/balloon: Enforce various limits on target

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 07/03/13 11:28, Daniel Kiper wrote:
> On Wed, Mar 06, 2013 at 05:52:28PM +0000, David Vrabel wrote:
>
>> If you set the target above d->max_pages you won't be able to populate them.
>>
>> So, using the maximum_reservation call seems like the right thing to me.
> 
> Please look above. If you use this value you would not
> be able to increase reservation.

I don't think I'm understanding the use case you're talking about.

Do you mean we should allow a target <= d->tot_pages even if this is
above d->max_pages?  I agree with this.

Something like this:

void balloon_set_new_target(unsigned long target)
{
        domid_t domid = DOMID_SELF;
        int rc;
        unsigned long host_limit;

        target = min(target, MAX_DOMAIN_PAGES);

        /* Prevent target from attempting the expand the reservation
           above the max enforced by the hypervisor. */
        rc = HYPERVISOR_memory_op(XENMEM_maximum_reservation, &domid);
        if (rc > 0) {
                host_limit = rc;
                target = min(target,
                        max(host_limit, balloon_stats.current_pages));
        }

        balloon_stats.target_pages = target;
        schedule_delayed_work(&balloon_worker, 0);
}

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel