Re: [Xen-devel] [RFC PATCH V4 15/18] Infrastructure to manipulate 3-level event channel pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.03.13 at 13:30, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> +    memcpy(d->evtchn_pending, &shared_info(d, evtchn_pending),
> +           sizeof(shared_info(d, evtchn_pending)));
> +    memcpy(d->evtchn_mask, &shared_info(d, evtchn_mask),
> +           sizeof(shared_info(d, evtchn_mask)));

Is there any point in this copying? If events area allowed to
exist (and potentially trigger) at this point, then it is unsafe
to do it this way. And if no active events are permitted, then
I don't see the need to copy anything here (just memset()
the space to the intended initial value).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel