Re: [Xen-devel] [PATCH] tools/xc: update tty detection in stdiostream_progress

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH] tools/xc: update tty detection in 
stdiostream_progress"):
> tools/xc: update tty detection in stdiostream_progress
> 
> As suggested by IanJ:
> Check isatty only once to preserve the errno of ->progress users, and to
> reduce the noice in strace output.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Thanks.  But how did you test this ?  It doesn't compile.

Also I think it would be better to name the struct member something
other than "isatty" since that's also the function name.  In theory it
should be OK but in practice I worry about compiler warnings etc.

How about "tty" ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel