[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] tools: Improve make deb



On Tue, 2013-02-26 at 12:58 +0000, Stefano Stabellini wrote:
> > +cat >deb/DEBIAN/postrm <<EOF
> > +#!/bin/bash -e
> > +insserv -r xendomains &&
> > +insserv -r xencommons
[...]
> All the changes look good to me

This one certainly isn't, calling insserv directly in a pre/post inst is
not the correct Debian interface to use.

Better to call update-rc.d I think, or use dh_installinit (and grow a
build time dependency on debhelper).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.