Re: [Xen-devel] [PATCH 2 of 7] tools/xc: handle tty output differently in stdiostream_progress

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Feb 22, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 2 of 7] tools/xc: handle tty output 
> differently in stdiostream_progress"):
> > tools/xc: handle tty output differently in stdiostream_progress
> > 
> > If the output goes to a tty, rewind the cursor and print everything in a
> > single line as it was done up to now. If the output goes to a file or
> > pipe print a newline after each progress output. This will fix logging
> > of progress messages from xc_save to xend.log.
> > 
> > To support XTL_STDIOSTREAM_SHOW_PID or XTL_STDIOSTREAM_SHOW_DATE print
> > the output via vmessage if the output is not a tty.
> 
> Can we lift the call to isatty out of the loop by calling it at
> setup ?
> 
> Calling it continually is undesirable not really for performance
> reasons but because it always trashes errno and because it will make
> strace output more noisy.

Ok, I will prepare a patch. I think that series is already applied.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel