Re: [Xen-devel] [PATCH] coverage: fix on ARM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-02-22 at 11:16 +0000, Jan Beulich wrote:
> >>> On 22.02.13 at 11:57, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > --- a/xen/arch/arm/xen.lds.S
> > +++ b/xen/arch/arm/xen.lds.S
> > @@ -91,12 +91,10 @@ SECTIONS
> >         *(.init.data.rel)
> >         *(.init.data.rel.*)
> >  
> > -       . = ALIGN(4);
> > -       __CTOR_LIST__ = .;
> > -       LONG((__CTOR_END__ - __CTOR_LIST__) / 4 - 2)
> > -       *(.ctors)
> > -       LONG(0)
> > -       __CTOR_END__ = .;
> > +       . = ALIGN(8);
> > +       __ctors_start = .;
> > +       *(.init_array)
> 
> Is this renaming from .ctors to .init_array really intended (i.e. was
> using .ctors here wrong)?

Yes, I mentioned it in the commit message, it is called .init_array on
ARM for whatever reason. Probably either historical accident or
compatibility eg. with ARM's compilers.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel