Re: [Xen-devel] [PATCH XEN] xen: event channel arrays are xen_ulong_t and not unsigned long

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.02.13 at 09:28, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2013-02-22 at 08:12 +0000, Jan Beulich wrote:
>> >>> On 21.02.13 at 18:16, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>> > On Tue, 2013-02-19 at 14:49 +0000, Ian Campbell wrote:
>> >> On ARM we want these to be the same size on 32- and 64-bit.
>> >> 
>> >> This is an ABI change on ARM. X86 does not change.
>> >> 
>> >> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >> Cc: Jan Beulich <JBeulich@xxxxxxxx>
>> >> Cc: Keir (Xen.org) <keir@xxxxxxx>
>> > 
>> > Are you guys (un)happy with this change from the Xen & x86 side?
>> 
>> I don't see any problem with it.
> 
> I'll take this as an Acked-by if that's ok with you.

Well, I specifically didn't say "ack": I don't really mind the change,
but I'm also not eager see it go in. Not seeing a problem with it
doesn't really mean there's none lurking - type changes in public
interfaces are always an at least slightly risky business.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel