Re: [Xen-devel] [PATCH 1/4] tools: s/arm/arm32/ in foreign header checks.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 14 Feb 2013, Ian Campbell wrote:
> Also define __arm__ARM32 as required.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Jan Beulich <JBeulich@xxxxxxxx>
> ---
> v2: s/x86_32/arm32/ in the right place
>     s/__arm__ARM32/__arm___ARM32/
>     Update gitignore

It looks OK to me

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  .gitignore                               |    2 +-
>  tools/include/xen-foreign/Makefile       |    4 ++--
>  tools/include/xen-foreign/mkheader.py    |    6 +++++-
>  tools/include/xen-foreign/reference.size |    2 +-
>  4 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 125a582..73c5b77 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -363,7 +363,7 @@ tools/include/xen-foreign/checker.c
>  tools/include/xen-foreign/structs.pyc
>  tools/include/xen-foreign/x86_32.h
>  tools/include/xen-foreign/x86_64.h
> -tools/include/xen-foreign/arm.h
> +tools/include/xen-foreign/arm32.h
>  
>  .git
>  tools/misc/xen-hptool
> diff --git a/tools/include/xen-foreign/Makefile 
> b/tools/include/xen-foreign/Makefile
> index cfaf790..5bc2d46 100644
> --- a/tools/include/xen-foreign/Makefile
> +++ b/tools/include/xen-foreign/Makefile
> @@ -3,7 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
>  
>  ROOT = $(XEN_ROOT)/xen/include/public
>  
> -architectures := arm x86_32 x86_64
> +architectures := arm32 x86_32 x86_64
>  headers := $(patsubst %, %.h, $(architectures))
>  
>  .PHONY: all clean check-headers
> @@ -22,7 +22,7 @@ check-headers: checker
>       diff -u reference.size tmp.size
>       rm tmp.size
>  
> -arm.h: mkheader.py structs.py $(ROOT)/arch-arm.h
> +arm32.h: mkheader.py structs.py $(ROOT)/arch-arm.h
>       $(PYTHON) $< $* $@ $(filter %.h,$^)
>  
>  x86_32.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_32.h 
> $(ROOT)/arch-x86/xen.h $(ROOT)/xen.h
> diff --git a/tools/include/xen-foreign/mkheader.py 
> b/tools/include/xen-foreign/mkheader.py
> index d189b07..eee28f3 100644
> --- a/tools/include/xen-foreign/mkheader.py
> +++ b/tools/include/xen-foreign/mkheader.py
> @@ -17,11 +17,15 @@ header = {};
>  footer = {};
>  
>  #arm
> -inttypes["arm"] = {
> +inttypes["arm32"] = {
>      "unsigned long" : "uint32_t",
>      "long"          : "uint32_t",
>      "xen_pfn_t"     : "uint64_t",
>  };
> +header["arm32"] = """
> +#define __arm___ARM32 1
> +""";
> +
>  
>  # x86_32
>  inttypes["x86_32"] = {
> diff --git a/tools/include/xen-foreign/reference.size 
> b/tools/include/xen-foreign/reference.size
> index a2cbfd6..9f1bfac 100644
> --- a/tools/include/xen-foreign/reference.size
> +++ b/tools/include/xen-foreign/reference.size
> @@ -1,5 +1,5 @@
>  
> -structs                   |     arm  x86_32  x86_64
> +structs                   |   arm32  x86_32  x86_64
>  
>  start_info                |       -    1112    1168
>  trap_info                 |       -       8      16
> -- 
> 1.7.2.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel