[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 27/46] xen: arm: arm64 trap handling.



On Thu, 2013-02-21 at 15:36 +0000, Tim Deegan wrote:
> At 15:25 +0000 on 21 Feb (1361460324), Ian Campbell wrote:
> > On Thu, 2013-02-21 at 15:10 +0000, Tim Deegan wrote:
> > > At 16:47 +0000 on 14 Feb (1360860461), Ian Campbell wrote:
> > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > > ---
> > > > v2: Call leave_hypervisor_tail on exit back to guest, disable 
> > > > interrupts while
> > > >     restoring state.
> > > 
> > > You don't seem to have addressed my other comments on v1:
> > 
> > I've got them in v3, I noted that I hadn't addresses you comment on this
> > patch in the #0/46.
> 
> So you did; I did read the 0/46, but for some reason all that stuck in
> my head was the WFE stuff. 
> 
> AFAICS you just need to re-roll this and #25,

I don't think you mean #25? That is "xen: arm64: add guest type to
domain field." which you've acked.

I had an outstanding comment for #14 "xen: arm64: barriers and wait for
interrupts/events" which I've just addressed (and reposted)

> and get a tools-person to ack #20.

Stefano perhaps? ;-)

> So for v3, can you just send those, and avoid another 46-patch
> mailbomb? :)

When I'm applying my own patches I prefer to do it from the list rather
than short cutting them from my own tree, keep me honest/from making
mistakes. How about I include an index of acked/unacked patches in the
zeroeth mail? You ought to be able to just mark it all as read.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.