[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: rework hypercall argument translation area setup


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Thu, 21 Feb 2013 12:57:17 +0000
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 21 Feb 2013 12:57:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac4QMvoOCtm57zQCk0u1UfNYkkRWpg==
  • Thread-topic: [Xen-devel] [PATCH] x86: rework hypercall argument translation area setup

On 21/02/2013 12:26, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Well, fine in principle. This manual setup/teardown of l2/l1 pagetables in
>> the perdomain area is getting a bit tiresome though isn't it? Isn't there
>> some setup helper that could be abstracted out for all users, and perhaps
>> even some automated teardown-and-freeing on domain destroy? I just sighed
>> when I saw more skanky pagetable manipulation for what is a conceptually
>> simple change.
> 
> I tried to spot pieces worth folding into helper functions, but
> didn't really find anything worthwhile (the purposes of the
> mappings are just too different). Perhaps we could have a
> map_pages_to_guest(), taking care of all intermediate page
> table levels? I can't see much else, and the main problem is that
> of tracking pages used for page tables here anyway.

Well, possibly even that might be an improvement.

> Are we concerned about the performance of guest GDT/LDT page
> (un)mappings?

LDT must often change on guest process context switch? So I would think yes
we do.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.