Re: [Xen-devel] [PATCH] build: Fix distclean when repo location changes

[Andrei Lifchits <andrei.lifchits@xxxxxxxxxx>]

On Wed, Feb 20, 2013 at 5:01 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2013-02-20 at 16:47 +0000, Andrei Lifchits wrote:
>> If the path to xen-unstable.hg changes (i.e. you move the repo), the symlinks
>> inside xen-unstable.hg/stubdom/libxc-x86_[32|64]/ all become broken, which
>> breaks distclean because make attempts to clean inside those first and fails 
>> to
>> find Makefile (which is also a symlink).

Signed-off-by: Andrei Lifchits <andrei.lifchits@xxxxxxxxxx>

> Would it be possible to arrange for the symlinks to be relative in the
> first place?

Good idea, I'll look into it when I have time (there are a lot of
those symlinks in various places).

>>
>> diff -r 66f563be41d9 -r 8f69a0bcab52 stubdom/Makefile
>> --- a/stubdom/Makefile        Tue Feb 19 10:49:53 2013 +0100
>> +++ b/stubdom/Makefile        Wed Feb 20 16:36:40 2013 +0000
>> @@ -501,7 +501,7 @@ clean:
>>       $(MAKE) -C vtpmmgr clean
>>       rm -fr grub-$(XEN_TARGET_ARCH)
>>       rm -f $(STUBDOMPATH)
>> -     [ ! -d libxc-$(XEN_TARGET_ARCH) ] || $(MAKE) DESTDIR= -C 
>> libxc-$(XEN_TARGET_ARCH) clean
>> +     [ ! -e libxc-$(XEN_TARGET_ARCH)/Makefile ] || $(MAKE) DESTDIR= -C 
>> libxc-$(XEN_TARGET_ARCH) clean
>>       -[ ! -d ioemu ] || $(MAKE) DESTDIR= -C ioemu clean
>>       -[ ! -d xenstore ] || $(MAKE) DESTDIR= -C xenstore clean
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> http://lists.xen.org/xen-devel
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel