Re: [Xen-devel] [PATCH] tools/libxc: perpare xc_domain_save for upcoming changes

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Feb 19, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH] tools/libxc: perpare xc_domain_save 
> for upcoming changes"):
> > tools/libxc: perpare xc_domain_save for upcoming changes
> > 
> > An upcoming patch will pass min_remaining to xc_domain_save.
> > Because such a will be an API change, take the opportunity to change the
> > API so that it will be easier to pass more options in the future.
> 
> I'm not sure why changing the large number of arguments to
> xc_domain_save to a struct is an improvement, even given that you are
> proposing to add one.  Can you explain further ?

If new parameters will be passed into xc_domain_save it will change the
API every time. If instead such parameters are stuffed into a struct the
API will not change for callers, if the new struct member is really
optional.

I'm fine with adding yet another parameter to xc_domain_save, given that
there are appearently no external callers. libvirt uses libxl.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel