Re: [Xen-devel] [PATCH LINUX] xen: event channel arrays are xen_ulong_t and not unsigned long

[Tim Deegan <tim@xxxxxxx>]

At 17:17 +0000 on 19 Feb (1361294248), Ian Campbell wrote:
> On Tue, 2013-02-19 at 17:11 +0000, Stefano Stabellini wrote:
> > On Tue, 19 Feb 2013, Ian Campbell wrote:
> > > +/*
> > > + * We cannot use xchg because it does not support 8-byte
> > > + * values. However it is safe to use {ldr,dtd}exd directly because all
> > > + * platforms which Xen can run on support those instructions.
> > > + */
> > > +static inline xen_ulong_t xchg_xen_ulong(xen_ulong_t *ptr, xen_ulong_t 
> > > val)
> > > +{
> > > +       xen_ulong_t oldval;
> > > +       unsigned int tmp;
> > > +
> > > +       wmb();
> > > +       asm volatile("@ read_evtchn_pending_sel\n"
> >                            ^ do we need this?
> 
> It means that the .s files (if you create them) and such are a bit more
> readable, it's not that uncommon in the ARM inline assembly.

+1.  s/read_evtchn_pending_sel/xchg_xen_ulong/ though.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel