Re: [Xen-devel] [PATCH] Switch to poll() in cxenstored's IO loop

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, 2013-02-15 at 14:52 +0000, Ian Campbell wrote:
> On Tue, 2013-02-05 at 13:31 +0000, Wei Liu wrote:
> 
> > -----8<----
> > From 22a7b50b8b0be62aeae7c86242a27dac1ffdb929 Mon Sep 17 00:00:00 2001
> > From: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Date: Mon, 21 Jan 2013 19:07:37 +0000
> > Subject: [PATCH] Switch to poll() in cxenstored's IO loop
> > 
> > Poll() can support more file descriptors than select(). We've done this for
> > xenconsoled, now do this for cxenstored as well.
> > 
> > The code is taken from xenconsoled and modified to adapt to cxenstored.
> > 
> > Updated:
> > * reopen pipe if polling on reopen_log_pipe fails.
> > * exit if polling on some critical fds fails.
> > * clean up POLL*.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Does this build for you? It fails to build for me in a fairly obvious
> way with:
>         xenstored_core.c:22:18: error: poll.h: No such file or directory
> followed by the inevitable fallout.
> 
> Oh, this is the stubdomain build! I suppose mini-os lacks poll support.
> 
> Faced with either making xenstored able to use poll or select as a
> compile time option and implementing poll for mini-os I'd probably go
> for the latter, presuming that most of the infrastructure is present
> already...
> 

Right. The header file is easy. Stefano introduced that years ago back
in 2008, but the implementation is missing.

Looking deeper in the code, poll is also missing in LWIP, but I think I
can skip that at the moment, or use lwip_select in Mini-OS's poll as
well...

Wei.

> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel