[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] AMD IOMMU: use __ioapic_read_entry() instead of open coding it



On 02/15/2013 11:22 AM, Jan Beulich wrote:
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>


--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -144,7 +144,7 @@ static void update_intremap_entry_from_i
int __init amd_iommu_setup_ioapic_remapping(void)
  {
-    struct IO_APIC_route_entry rte = {0};
+    struct IO_APIC_route_entry rte;
      unsigned long flags;
      u32* entry;
      int apic, pin;
@@ -159,9 +159,7 @@ int __init amd_iommu_setup_ioapic_remapp
      {
          for ( pin = 0; pin < nr_ioapic_entries[apic]; pin++ )
          {
-            *(((int *)&rte) + 1) = io_apic_read(apic, 0x11 + 2 * pin);
-            *(((int *)&rte) + 0) = io_apic_read(apic, 0x10 + 2 * pin);
-
+            rte = __ioapic_read_entry(apic, pin, 1);
              if ( rte.mask == 1 )
                  continue;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.