Re: [Xen-devel] [PATCH] tools/libxl: Added vga parameter for hvm domUs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

fantonifabio@xxxxxxxxxx writes ("[Xen-devel] [PATCH] tools/libxl: Added vga 
parameter for hvm domUs"):
> From: Fabio Fantoni <fabio.fantoni@xxxxxxxxxx>
> 
> Usage:
>   vga="stdvga"|"cirrus"
> 
> - Default option is cirrus.
> - Prints error and exit if unknown value is passed.
> - stdvga parameter is now deprecated.
> - Updated xl.cfg man.
> 
> Required patch: Improve videoram setting v5
> Is prerequisite for patch: Add qxl support v9

The code looks good to me, but there are a couple of formatting
problems.  Your wrapping of the longer lines is odd (particularly, you
fail to indent the continuations), and there's a spurious space after
xlu_cfg_get_string.  Can you please repost following the style used
elsewhere ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel