[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 32/45] xen: arm: show_registers() support for 64-bit.



On Thu, 2013-02-14 at 15:10 +0000, Ian Campbell wrote:
> On Thu, 2013-02-14 at 14:59 +0000, Tim Deegan wrote:
> > At 15:56 +0000 on 23 Jan (1358956598), Ian Campbell wrote:
> > > -static void _show_registers(struct cpu_user_regs *regs,
> > > -                            struct reg_ctxt *ctxt,
> > > -                            int guest_mode)
> > > +
> > > +static void _show_registers_32(struct cpu_user_regs *regs,
> > 
> > Can we drop the _extraneous _underscore while we're here?
> 
> yes.

I did this, although note that the call chain is
        show_registers -> _show_registers -> show_registers_(32|64)
or
        vcpu_show_registers -> _show_registers -> ...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.