Re: [Xen-devel] [PATCH v2 3/4] libxc: fixes for the ARM platform

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-01-24 at 17:40 +0000, Ian Campbell wrote:
> On Wed, 2013-01-16 at 18:58 +0000, Stefano Stabellini wrote:
> > Make xc_dom_feature_translated an arch-dependent function.
> > 
> > alloc_magic_pages: save console and xenstore pfn's in xc_dom_image.
> > alloc_magic_pages: set HVM_PARAM_CONSOLE_EVTCHN and
> > HVM_PARAM_STORE_EVTCHN hvm_params using the event channels allocated by
> > the toolstack.
> > 
> > Call xc_dom_gnttab_hvm_seed instead of xc_dom_gnttab_seed in
> > xc_dom_gnttab_init for autotranslated guests.
> > 
> > 
> > Changes on v2:
> > - add xc_dom_gnttab_init changes.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This change broke the x86_64 build (at least, presumalby 32 too)
        
        gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing 
-std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement   
-D__XEN_TOOLS__ -MMD -MF .xc_core.o.d  -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -D_GNU_SOURCE  
-I../../xen/common/libelf -Werror -Wmissing-prototypes -I. 
-I/local/scratch/ianc/devel/arm/xen-unstable/tools/libxc/../../tools/include 
-pthread  -c -o xc_core.o xc_core.c 
        cc1: warnings being treated as errors
        In file included from xc_core.h:154,
                         from xc_core.c:66:
        xc_core_x86.h: In function âxc_dom_feature_translatedâ:
        xc_core_x86.h:39: error: implicit declaration of function 
âelf_xen_feature_getâ
        xc_core_x86.h:39: error: dereferencing pointer to incomplete type
        In file included from xc_dom.h:18,
                         from xc_core.c:67:
        
/local/scratch/ianc/devel/arm/xen-unstable/tools/libxc/../../tools/include/xen/libelf/libelf.h:
 At top level:
        
/local/scratch/ianc/devel/arm/xen-unstable/tools/libxc/../../tools/include/xen/libelf/libelf.h:266:
 error: static declaration of âelf_xen_feature_getâ follows non-static 
declaration
        xc_core_x86.h:39: note: previous implicit declaration of 
âelf_xen_feature_getâ was here
        
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel