Re: [Xen-devel] [PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD passthrough

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.02.13 at 12:30, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
wrote:
> On Thu, 7 Feb 2013, G.R. wrote:
>> >
>> > For one I wonder whether this is really _always_ correct. I.e.
>> > the device at 00:1f.0 always being an ISA bridge. Wouldn't it
>> > be better to mirror whatever the host device says?
>> >
>> >From the Intel driver code, it's looking for an intel ISA bridge.
>> So your question would be should it be always at 00:1f.0.
>> So far it seems that it is.
>> 
>> > And then I don't see why you need to open code all of
>> > pci_bridge_init() instead of just overriding the class value after
>> > you called that function (or, if the order of events for some
>> > reason matters, adding another parameter to the function).
>> 
>> Stefano, could you comment? It's your code after all.
> 
> It's not trivial because PCIBus is defined in hw/pci.c, so you can't
> dereference members of PCIBus from hw/pt-graphics.c.

But the patch makes it so the structure itself becomes public?
What problem do you see?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel