Re: [Xen-devel] [Patch 2/2] Compile errors with gcc 4.8

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.02.13 at 00:25, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
> On Thu, 7 Feb 2013, Jan Beulich wrote:
> 
>>>>> On 06.02.13 at 21:37, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
>>> @@ -264,7 +264,7 @@
>>>                return -1;
>>>        }
>>>
>>> -       memset(buf,0,sizeof(buf));
>>> +       memset(buf,0,sizeof(*buf));
>>
>> While everything else looks right, this one for sure is wrong - buf
>> is an array, and hence sizeof(*buf) would clear just the first array
>> element.
> 
> Yes, I now agree it is wrong (I found the other example in that file and 
> assumed this one was broken as well). I am attaching a patch that fixes 
> the other cases.

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Ian - please also consider applying to the 4.x trees.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel