Re: [Xen-devel] [PATCH 2/4] cover: Adding support for coverage information

[Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>]

On Thu, 2013-02-07 at 11:59 +0000, George Dunlap wrote:
> On 07/02/13 11:28, Frediano Ziglio wrote:
> > diff --git a/xen/common/gcov/gcov.c b/xen/common/gcov/gcov.c
> > new file mode 100644
> > index 0000000..733d020
> > --- /dev/null
> > +++ b/xen/common/gcov/gcov.c
> > @@ -0,0 +1,74 @@
> > +/*
> > + *  This code maintains a list of active profiling data structures.
> > + *
> > + *    Copyright IBM Corp. 2009
> > + *    Author(s): Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
> > + *
> > + *    Uses gcc-internal data definitions.
> > + *    Based on the gcov-kernel patch by:
> > + *       Hubertus Franke <frankeh@xxxxxxxxxx>
> > + *       Nigel Hinds <nhinds@xxxxxxxxxx>
> > + *       Rajan Ravindran <rajancr@xxxxxxxxxx>
> > + *       Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
> > + *       Paul Larson
> > + */
> > +
> > +#include <xen/config.h>
> > +#include <xen/init.h>
> > +#include <xen/lib.h>
> > +#include <xen/hypercall.h>
> > +#include <xen/gcov.h>
> > +#include <xen/errno.h>
> > +
> > +static struct gcov_info *info_list;
> > +static unsigned num_info = 0;
> 
> This is a bit of a nit, but you seem to remove this variable in the next 
> patch, which is bad form.  If it's not necessary, just don't add it in 
> this patch.
> 
> > +
> > +/*
> > + * __gcov_init is called by gcc-generated constructor code for each object
> > + * file compiled with -fprofile-arcs.
> > + *
> > + * Although this function is called only during initialization is called 
> > from
> > + * a .text section which is still present after initialization so not 
> > declare
> > + * as __init.
> > + */
> > +void __gcov_init(struct gcov_info *info)
> > +{
> > +    /* add new profiling data structure to list */
> > +    info->next = info_list;
> > +    info_list = info;
> > +    ++num_info;
> 
> Ditto.
> 
>   -George
> 

Done

Frediano

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel