Re: [Xen-devel] [PATCH 03/45] xen: arm: rename atag_paddr argument fdt_paddr

[Tim Deegan <tim@xxxxxxx>]

At 15:56 +0000 on 23 Jan (1358956569), Ian Campbell wrote:
> We don't support ATAGs and this is always actually an FDT address.

Should we also change the code in head.S that call this an ATAG?

Tim.

> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  xen/arch/arm/setup.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 7e35860..0837db3 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -329,7 +329,7 @@ void __init setup_cache(void)
>  
>  /* C entry point for boot CPU */
>  void __init start_xen(unsigned long boot_phys_offset,
> -                      unsigned long atag_paddr,
> +                      unsigned long fdt_paddr,
>                        unsigned long cpuid)
>  {
>      void *fdt;
> @@ -341,7 +341,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>      smp_clear_cpu_maps();
>  
>      fdt = (void *)BOOT_MISC_VIRT_START
> -        + (atag_paddr & ((1 << SECOND_SHIFT) - 1));
> +        + (fdt_paddr & ((1 << SECOND_SHIFT) - 1));
>      fdt_size = device_tree_early_init(fdt);
>  
>      cpus = smp_get_max_cpus();
> @@ -365,7 +365,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>      set_current((struct vcpu *)0xfffff000); /* debug sanity */
>      idle_vcpu[0] = current;
>  
> -    setup_mm(atag_paddr, fdt_size);
> +    setup_mm(fdt_paddr, fdt_size);
>  
>      /* Setup Hyp vector base */
>      WRITE_CP32((uint32_t) hyp_traps_vector, HVBAR);
> -- 
> 1.7.2.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel