Re: [Xen-devel] [PATCH] libxl: pass debug flag down to libxl_domain_suspend

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-02-05 at 14:16 +0000, Olaf Hering wrote:
> On Tue, Feb 05, Ian Campbell wrote:
> 
> > On Thu, 2013-01-31 at 16:05 +0000, Olaf Hering wrote:
> > > # HG changeset patch
> > > # User Olaf Hering <olaf@xxxxxxxxx>
> > > # Date 1359648298 -3600
> > > # Node ID 256d59b2bc8a413876559dc8daf4c52ba46677de
> > > # Parent  12455da211d4e841692b2374086356a87eb74ff7
> > > libxl: pass debug flag down to libxl_domain_suspend
> > > 
> > > libxl_domain_suspend is already prepared to handle LIBXL_SUSPEND_DEBUG,
> > > and xl migrate handles the -d switch as well. Pass this flag down to
> > > libxl_domain_suspend, so that finally xc_domain_save can dump huge
> > > amount of debug data to stdout.
> > > Update xl.5 and help text output.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > > 
> > > diff -r 12455da211d4 -r 256d59b2bc8a docs/man/xl.pod.1
> > > --- a/docs/man/xl.pod.1
> > > +++ b/docs/man/xl.pod.1
> > > @@ -387,6 +387,10 @@ domain. See the corresponding option of 
> > >  
> > >  Send <config> instead of config file from creation.
> > >  
> > > +=item B<-e>
> > 
> > You mean -d here.
> > 
> > I wonder if we should make this option a bit more obscure (e.g. a long
> > option only) ? Or tie it to verbose > 5 or something?
> 
> I'm not sure how to create a long only option.

I've not tried it but I think where normally for -c/--cpus you would
have:
        {"cpus", 0, 0, 'c'},
        ...
        case 'c': ...

You can also have non-char keys in the last field (val) e.g.
        {"foo", 0, 0, 0x100},
        ...
        case 0x100: ...

(0x100 because that's not an ascii character so no clash).

>  But if it has to be
> specified two or three times to really enable it, that would be ok for
> me. Will send v3 of this change shortly.

I was trying to avoid swallowing one of the lower case letters (which
are finite) for a rarely used debug option, rather than worrying about
people enabling it by mistake, so -d -d -d doesn't really help.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel