[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xencommons: redirect serial and parallel to /dev/null
On Mon, 2013-01-28 at 18:48 +0000, Stefano Stabellini wrote: > Upstream QEMU doesn't support -nographic with -daemonize unless monitor, > serial and parallel outputs are all redirected: > > /* According to documentation and historically, -nographic redirects > * serial port, parallel port and monitor to stdio, which does not work > * with -daemonize. We can redirect these to null instead, but since > * -nographic is legacy, let's just error out. > * We disallow -nographic only if all other ports are not redirected > * explicitly, to not break existing legacy setups which uses > * -nographic _and_ redirects all ports explicitly - this is valid > * usage, -nographic is just a no-op in this case. > */ > > Considering that we do want to redirect them to /dev/null anyway, do so. > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > Tested-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx> I think I asked you IRL if this would work with older QEMU too and IIRC you said yes, so : Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Applied, I had to adjust because of 26352:9a1610c1e564 "xencommons: Stop QEMU in do_stop()" and I rewrapped it since the line was getting a bit ridiculous, let me know if I did it wrong... _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |