Re: [Xen-devel] [PATCH 4/4] xen: arm: create dom0 DTB /hypervisor/ node dynamically.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-02-05 at 11:26 +0000, Anthony PERARD wrote:
> > +static void make_hypervisor_node(void *fdt, int addrcells, int sizecells)
> > +{
> > +    const char compat[] = "xen,xen-4.2\0xen,xen";
> > +    u32 reg[4];
> > +    u32 intr[3];
> > +    u32 *cell;
> > +
> > +    /*
> > +     * Sanity-check address sizes, since addresses and sizes which do not 
> > take
> > +     * up exactly 4 or 8 bytes are not supported.
> > +     */
> > +    if ((addrcells != 1 && addrcells != 2) ||
> > +        (sizecells != 1 && sizecells != 2))
> > +        panic("Cannot cope with this size");
> 
> You could add those two properties in the hypervisor node if they don't
> match what we expect them to be. This would avoid panicking with a
> device tree that have different default values.

Yes, I suppose that ought to work.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel