Re: [Xen-devel] [PATCH 2/2] xl: allow specifying a default netdev in xl.conf

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-01-28 at 11:00 +0000, George Dunlap wrote:
> On Fri, Jan 25, 2013 at 3:26 PM, Roger Pau Monne
> <roger.pau@xxxxxxxxxx> wrote:
>         This adds a new global option in the xl configuration file
>         called
>         "defaultnetdev", that is used to specify the default netdev to
>         use
>         when none is passed in the vif specification.
> 
> 
> I'm not a fan of the name, though; it doesn't seem very scalable.  It
> looks like we already have "defaultbridge', so I can see this is just
> following precedent, but I wonder if it might be worth putting some
> more thought into it before proceeding?
> 
> 
> It seems like if we're going to have a default sub-option, it should
> at least have the name of the option in which it resides.
> "vif_netdev_default" or "default_vif_netdev" seem like better option.
> Or maybe "vif.netdev.default"? "defaults.vif.netdev"?

netdev is also a bit non-descriptive, even if it is what the vif-route
script uses perhaps we present something more meaningful to the user?

"gatewaydev" or something along those lines perhaps?

I'd be inclined to use whatever name we decide here in the libxl
API/internals as well and just go netdev at the hotplug script
interface.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel