Re: [Xen-devel] [PATCH 1/2] Adding support for coverage information

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.02.13 at 18:08, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -103,6 +103,11 @@ subdir-all := $(subdir-y) $(subdir-n)
>  
>  $(filter %.init.o,$(obj-y) $(obj-bin-y)): CFLAGS += -DINIT_SECTIONS_ONLY
>  
> +
> +ifeq ($(coverage),y)
> +$(filter-out %.init.o,$(obj-y) $(obj-bin-y)): CFLAGS += -fprofile-arcs 
> -ftest-coverage -DTEST_COVERAGE
> +endif

So you had tried out the simplified version of this that I had
suggested, it worked, yet you still don't use it?

> +void init_coverage(void)

As already said previously: __init!

> +#ifdef TEST_COVERAGE
> +void __init init_coverage(void);

And as also already said previously - no __init on declarations!

Please, don't waste reviewers' time by claiming you incorporated
review comments when you really didn't.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel