Re: [Xen-devel] [PATCH 04/16] Move event channel macros / struct definition to proper place

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, 2013-02-04 at 09:00 +0000, Jan Beulich wrote:
> >>> On 31.01.13 at 15:42, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/include/public/xen.h
> > +++ b/xen/include/public/xen.h
> > @@ -557,6 +557,8 @@ DEFINE_XEN_GUEST_HANDLE(multicall_entry_t);
> >   *  1024 if a long is 32 bits; 4096 if a long is 64 bits.
> >   */
> >  #define NR_EVENT_CHANNELS (sizeof(unsigned long) * sizeof(unsigned long) * 
> > 64)
> > +#define EVTCHNS_PER_BUCKET 128
> > +#define NR_EVTCHN_BUCKETS  (NR_EVENT_CHANNELS / EVTCHNS_PER_BUCKET)
> 
> These aren't part of the hypercall ABI, and hence don't belong here.
> What is preventing you from putting them alongside the other
> stuff you move to xen/include/xen/event.h?
> 

That would cause circular inclusion and break the build.

a) sched.h: struct domain reference NR_EVTCHN_BUCKETS
b) event.h: refereces sched.h

Now a second thought come to me, a clean fix would be that I make the
allocation of evtchn in struct domain first, then move those macros /
definitions to proper place.


Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel