Re: [Xen-devel] Correct DTB compatibility for xen /hypervisor node?

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-01-30 at 16:42 +0000, Stefano Stabellini wrote:
> On Wed, 30 Jan 2013, Ian Campbell wrote:
> > On Mon, 2013-01-28 at 16:50 +0000, Ian Campbell wrote:
> > > Looks like we have both 4.2 and 4.3 in use. Which should it be?
> > > 
> > > $ rgrep xen-4 arch/arm Documentation/
> > > arch/arm/boot/dts/xenvm-4.2.dts:          compatible = "xen,xen-4.2", 
> > > "xen,xen";
> > > Documentation/devicetree/bindings/arm/xen.txt:    compatible = 
> > > "xen,xen-4.3", "xen,xen";
> > > 
> > > FWIW I've always used 4.2 in my own DTB files.
> > > 
> > > Strictly speaking the API is the Xen 3.x API, but that doesn't seem
> > > terribly relevant.
> > > 
> > > I suppose arch_get_xen_caps ought to return something consistent?
> > 
> > On a related note should /hypervisor contain #interrupt-cells = <3> ?
> > We use "interrupts = <1 15 0xf08>" so it is somewhat implicit, butsince
> > the parent doesn't have anything explicit this it will default to
> > $somethingelse (0)? 
> 
> I think that it is implicit that the interrupts attributes follow the
> rules specified by the interrupt controller node.

OK.

> > Should Documentation/devicetree/bindings/arm/xen.txt also reference
> > gic.txt for the meaning of the fields, or are we free to define our own
> > meaning?
> 
> No, we are not. Referencing gic.txt is a good idea.

Yes, especially since we assume that interrupt-controller == gic.

> > We need to get a canonical copy of this binding doc into the hypervisor
> > tree too.
> 
> Right.

Are you going to send a patch to both Linux and Xen?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel