[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH] Adding support for coverage informations

>>> On 29.01.13 at 13:58, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
> On Tue, 2013-01-29 at 10:41 +0000, Jan Beulich wrote:
>> >>> On 28.01.13 at 22:16, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
>> > Do anybody know why I had to exclude %.init.o files to make it compile?
>> Without you telling us what problems not doing so causes, no.
> Xen didn't compile. In xen/Rules.mk there is code that change if
> *.init.o do not contain some sections (text/data/bss).

Ah - you'd then have to decide whether these sections should
get converted (their names prefixed by .init.*) or whether these
files (as being init-only) would better be excluded from this
mechanism (which si sort of what you're doing right now).

>> > +#ifdef CONFIG_COMPAT
>> > +int compat_coverage_op(int op, int idx, XEN_GUEST_HANDLE_PARAM(void) 
>> > uarg, int arg2)
>> > +{
>> > +    return -EINVAL;
>> > +}
>> > +#endif
>> By suitably defining the interface structures you can avoid the
>> need for a separate compat handler.
> How to do it?

Just define all fields such that both size and alignment match
between 32- and 64-bit views on them.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.