Re: [Xen-devel] [PATCH 2/8] docs: Provide some examples of the various ELF values.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-01-28 at 18:32 +0000, Konrad Rzeszutek Wilk wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  xen/include/public/elfnote.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/xen/include/public/elfnote.h b/xen/include/public/elfnote.h
> index 3c57a06..74223dd 100644
> --- a/xen/include/public/elfnote.h
> +++ b/xen/include/public/elfnote.h
> @@ -48,14 +48,19 @@
>  /*
>   * The virtual address of the entry point (numeric).
>   *
> + * Example is 0xffffffff81899200.

I'm not convinced that many of these add much, especially these "random
number" ones. It would be better if it could link to some suitable
documentation about the context of the field (or perhaps you are about
to add some such documentation later in this series).

> @@ -82,6 +89,8 @@
>  /*
>   * The version of Xen that we work with (string).
>   *
> + * Example is "xen-3.0"

I think this one is effectively "must always be xen-3.0" since the API
has been frozen since 3.0.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel