Re: [Xen-devel] [PATCH 2/6] x86/HVM: consolidate toggling of RTC IRQ

[Keir Fraser <keir@xxxxxxx>]

On 23/01/2013 08:09, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> @@ -442,8 +442,7 @@ static int rtc_ioport_write(void *opaque
>          if ((data & RTC_UIE) && !(s->hw.cmos_data[RTC_REG_B] & RTC_UIE))
>              if (s->hw.cmos_data[RTC_REG_C] & RTC_UF)
>              {
> -                hvm_isa_irq_deassert(d, RTC_IRQ);
> -                hvm_isa_irq_assert(d, RTC_IRQ);
> +                rtc_toggle_irq(s);
>              }

Was it a bug that RTC_IRQF was not being set here before? Changeset comment
should mention it is a bugfix as well as code reorganisation in that case.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel