Re: [Xen-devel] [PATCH] x86: restore (optional) forwarding of PCI SERR induced NMI to Dom0

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/01/13 16:57, Jan Beulich wrote:
>>>> On 21.01.13 at 17:16, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 21/01/13 16:11, Jan Beulich wrote:
>>> --- a/xen/include/public/nmi.h
>>> +++ b/xen/include/public/nmi.h
>>> @@ -36,9 +36,14 @@
>>>   /* I/O-check error reported via ISA port 0x61, bit 6. */
>>>  #define _XEN_NMIREASON_io_error     0
>>>  #define XEN_NMIREASON_io_error      (1UL << _XEN_NMIREASON_io_error)
>>> + /* PCI SERR reported via ISA port 0x61, bit 7. */
>>> +#define _XEN_NMIREASON_pci_serr     1
>>> +#define XEN_NMIREASON_pci_serr      (1UL << _XEN_NMIREASON_pci_serr)
>>> +#if __XEN_INTERFACE_VERSION__ < 0x00040300 /* legacy alias of the above */
>>>   /* Parity error reported via ISA port 0x61, bit 7. */
>> These seem wrong.  Both SERR and Parity error have the same comment and
>> definition.
> Sure - did you look at the history of this (particularly the c/s
> mentioned in the description)?
>
>> Furthermore, the definition disagrees with the comment.
> In what way?
>
> Jan
>

Ah - I missed that being in public, and was thinking that you were
attempting to use (1UL<<1) to test against bit 7.  My mistake - sorry.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel